fix: get signing key by pub key user check#1950
Open
mjuchli-da wants to merge 6 commits into
Open
Conversation
Signed-off-by: Marc Juchli <marc.juchli@digitalasset.com>
pawelstepien-da
approved these changes
Jun 8, 2026
pawelstepien-da
requested changes
Jun 8, 2026
pawelstepien-da
left a comment
pawelstepien-da
left a comment
Contributor
There was a problem hiding this comment.
Changes look good, but it exposed an issue in wallet-kernel signing driver - it uses signing store without auth and therefore assertConnected fails when driver calls getSigningKeyByPublicKey during wallet creation.
Signed-off-by: Marc Juchli <marc.juchli@digitalasset.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…-sql-tests Signed-off-by: Marc Juchli <marc.juchli@digitalasset.com>
mjuchli-da
commented
Jun 8, 2026
| internalTxId: params.internalTxId, | ||
| }), | ||
| userIdentifier: userId, | ||
| userIdentifier: authContext?.email, |
Contributor
Author
There was a problem hiding this comment.
userId used to be the email as far as i can see.
please double-check @pawelstepien-da
Contributor
There was a problem hiding this comment.
Yes we definitely used value from email here. In BD signing driver controller the argument was called userId, it was typed as userId: AuthContext['userId'], but it was actually supposed to be email, so it was quite confusing and is so much clearer now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.