Skip to content

feat: upgrade openstacksdk #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rpocase wants to merge 2 commits into
base: main
Choose a base branch
from
+426 −5,034
Open

feat: upgrade openstacksdk #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aef156
chore: drop Python 3.8 support
rpocase Jul 24, 2026
c651c91
feat: upgrade openstacksdk and python-openstackclient
rpocase Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1!11.1.2
1!12.0.0
8 changes: 3 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "hatchling.build"

[project]
dynamic = ["version"]
requires-python = ">=3.8"
requires-python = ">=3.10"
name = "pycloudlib"
description = "Python library to launch, interact, and snapshot cloud instances"
classifiers = [
Expand All @@ -14,8 +14,6 @@ classifiers = [
"Natural Language :: English",
"Operating System :: POSIX :: Linux",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Expand All @@ -37,11 +35,11 @@ dependencies = [
"ibm-vpc >= 0.10, < 0.29.0",
"knack >= 0.7.1",
"oci >= 2.17.0",
"openstacksdk >= 1.1.0, < 1.5.0",
"openstacksdk >= 4.2.0, < 4.9.0",

@blackboxsw blackboxsw Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge bump in openstackSDK, can we provide a separate commit to all self.conn changes to align with latest openstacksdk API changes?

It looks to me like we'd expect to see methods hung off of separate self.conn.compute, self.conn.network or self.conn.image. For example, instead of top-level self.conn.create_floating_ip we should be able to use the self.conn.network.create_ip method.

"paramiko >= 2.9.2",
"protobuf",
"pyparsing >= 2, < 3.0.0",
"python-openstackclient >= 5.2.1",
"python-openstackclient >= 5.2.1, < 8.3.0",
"pyyaml >= 5.1",
"qemu.qmp >= 0.0.3",
"requests >= 2.22",
Expand Down
8 changes: 1 addition & 7 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
requires =
tox-uv
# As it may be undesired to make formatting changes, by default only check
envlist = ruff, mypy, py38
envlist = ruff, mypy, py310
skipsdist = true

[common]
Expand All @@ -18,12 +18,6 @@ commands = {envpython} -m pytest --doctest-modules --cov=pycloudlib --cov-branch
[testenv:py38]
envdir = {[common]envdir}
deps = {[common]deps}
basepython = python3.8

@blackboxsw blackboxsw Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we retain an explicit [testenv:python10] in tox.ini instead of just removing testenv:py38

commands = {[testenv:pytest]commands}

[testenv:py310]
envdir = {[common]envdir}
deps = {[common]deps}
basepython = python3.10
commands = {[testenv:pytest]commands}

Expand Down
Loading