This repository was archived by the owner on Mar 27, 2026. It is now read-only.
docs: for apt, clarify that add_package doesn't raise PackageNotFoundError - #167
Merged
Merged
Conversation
dwilding
marked this pull request as ready for review
August 21, 2025 12:07
james-garner-canonical
approved these changes
Aug 21, 2025
james-garner-canonical
left a comment
james-garner-canonical
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking care of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing the apt library, I noticed that
add_packagedoesn't raisePackageNotFoundErrorif any packages aren't found. Instead, the function raisesPackageError. That's becauseadd_packagerelies on a function_addto add each package, and_addcatchesPackageNotFoundErrorand returns a boolean instead.This PR updates the relevant docs to clarify when
PackageNotFoundErroris raised. Matches canonical/charmlibs#124