nullbootctl: Sync the ESP and improve comments#139
Merged
Conversation
Pull Request Test Coverage Report for Build 18729579563Details
💛 - Coveralls |
Contributor
Author
|
This needs testing and I need to update my signing key, GitHub doesn't seem to want to pull in new signatures itself and doesn't provide a way to update the key with news ones, sigh (key expiry is every 2 years I believe, and I resign them earlier) |
Sync the ESP between copying in the kernels and adding them to the boot order so they are written to the backing storage before the boot order is updated. This also ensures that when kernels are removed later, the new kernels are there so there always is a bootable path. Also add additional documentation strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync the ESP between copying in the kernels and adding them to the boot order so they are written to the backing storage before the boot order is updated.
This also ensures that when kernels are removed later, the new kernels are there so there always is a bootable path.
Also add additional documentation strings.