fix(mount): settle udev before mounting filesystems - #7082
Open
balakreddy wants to merge 1 commit into
Open
Conversation
Wait for pending udev events before running mount -a. This ensures mount uses current filesystem information after a disk has been reformatted. fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2525858 Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
Author
|
Adding @jeremycline |
Member
|
It looks like this is working around a behavior change in util-linux? Waiting for udev to settle usually is usually a hack. Is there a better fix? |
Yeah, this is from util-linux/util-linux@8bdc254. Another option is to have cloud-init write the filesystem type in the fstab entry, assuming it knows it in all cases. Others have hit this in util-linux (util-linux/util-linux#4527) so it's possible they'll reconsider the change, although I expect they were aware of the nature of udev when they started using it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for pending udev events before running mount -a. This ensures mount uses current filesystem information after a disk has been reformatted.
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2525858
Additional Context
Test Steps
Merge type