chore(nocloud): enable untyped function checks - #7075
Open
dwaradwara wants to merge 1 commit into
Open
Conversation
Add typing needed for strict function-body checking and remove the NoCloud check_untyped_defs exemption. Refs canonicalGH-5445
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Enable strict function-body type checking for DataSourceNoCloud.
This adds the type information required by mypy, removes
DataSourceNoCloud from the check_untyped_defs exemption, and annotates
the shared DataSource _platform_type attribute to match its existing
string-or-None behavior.
No intended runtime behavior changes.
Test Steps
NoCloud unit tests: 19 passed.
Merge type