systemd: replace TimeoutSec=0 with TimeoutSec=300 in network stage - #7055
Closed
sundeep8967 wants to merge 2 commits into
Closed
systemd: replace TimeoutSec=0 with TimeoutSec=300 in network stage#7055sundeep8967 wants to merge 2 commits into
sundeep8967 wants to merge 2 commits into
Conversation
When rendering schema property documentation, module_property.tmpl previously appended 'Each object in <name> list supports the following keys:' to all properties with nested properties, regardless of whether the property was an array of items or a single object. Fix module_property.tmpl to distinguish between list types (items) and single object types (properties/patternProperties directly), rendering 'The <name> object supports the following keys:' for object properties. Fixes canonicalGH-7046
Boot deadlocks can occur in the network stage if a cyclic dependency prevents a start job from becoming runnable (e.g. systemd-networkd-wait-online.service). TimeoutSec=0 allows the service to hang indefinitely, rendering the host unbootable. This change imposes a 300s upper bound on the network stage so that if it hangs, the service fails and the boot sequence can continue. Fixes canonicalGH-7052 Signed-off-by: sundeep8967 <sundeep8967@gmail.com>
github-actions
Bot
added
the
documentation
Contributor
Author
|
Closing as a duplicate of #7053. Apologies for the noise, I didn't see the existing PR before submitting. |
Contributor
Author
|
closing this as duplicate of #7053. didn't see the earlier pr, my bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using systemd-networkd-wait-online.service in the network stage, a cyclic dependency or failed transaction can cause
systemctl start systemd-networkd-wait-online.serviceto block indefinitely. Sincecloud-init-network.serviceships withTimeoutSec=0, it waits forever, deadlocking the entire boot process before sshd or user services can start.Solution
TimeoutSec=0withTimeoutSec=300insystemd/cloud-init-network.service.tmpl.Fixes #7052
Testing