Conversation
Move the check for a valid problem report key to the helper function `_check_problem_report_key` to make it reusable.
Apport report files consist of key/value pairs based on the standard RFC822 format, except that Apport uses case sensitive keys. Key names must only contain numbers, letters, '.', '_', and '-'. This is validated in `ProblemReport.__setitem__`, but not when extracting a report in `ProblemReport.extract_keys`. So use `_check_problem_report_key` in `ProblemReport.extract_keys` before contructing a path from the key. Bug: https://launchpad.net/bugs/2167360
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
- Coverage 84.48% 84.46% -0.02%
==========================================
Files 106 106
Lines 21038 21049 +11
Branches 3184 3186 +2
==========================================
+ Hits 17773 17780 +7
Misses 2795 2795
- Partials 470 474 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apport report files consist of key/value pairs based on the standard RFC822 format, except that Apport uses case sensitive keys. Key names must only contain numbers, letters, '.', '_', and '-'. This is validated in
ProblemReport.__setitem__, but not when extracting a report inProblemReport.extract_keys.So use
_check_problem_report_keyinProblemReport.extract_keysbefore contructing a path from the key.Bug: https://launchpad.net/bugs/2167360