Conversation
varranvar
force-pushed
the
fix-lp-1784116
branch
2 times, most recently
from
August 28, 2026 15:22
dae2366 to
96f172f
Compare
The get_file_package() function unconditionally stripped the ":arch" qualifier from the matched dpkg .list filename. On multiarch systems, a file owned by a foreign-architecture package then resolved via the bare name to the native-arch package, which is often not installed, will cause a spurious package not installed error message (LP: #1784116). This fix is to only strip the qualifier when it matches the system architecture and keep it for foreign architectures so the name resolves to the installed package.
varranvar
force-pushed
the
fix-lp-1784116
branch
2 times, most recently
from
August 28, 2026 15:34
dae2366 to
c1945ef
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 84.48% 84.49% +0.01%
==========================================
Files 106 106
Lines 21038 21055 +17
Branches 3184 3192 +8
==========================================
+ Hits 17773 17790 +17
+ Misses 2795 2794 -1
- Partials 470 471 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cover keeping the ":arch" qualifier for foreign-architecture packages and stripping it for native-architecture and unqualified packages (LP: #1784116). Signed-off-by: Varun Varma <varun.varma@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_file_package() function unconditionally stripped the ":arch" qualifier from the matched dpkg .list filename. On multiarch systems, a file owned by a foreign-architecture package then resolved via the bare name to the native-arch package, which is often not installed, will cause a spurious package not installed error message (LP: #1784116).
This fix is to only strip the qualifier when it matches the system architecture and keep it for foreign architectures so the name resolves to the installed package.