Repository navigation
fix(docs): resize the favorites' scenes and card posters to the 1440px grid - #240
Merged
hunterbecton merged 1 commit intoOct 9, 2026
Conversation
…x grid SHA-218 narrowed the favorites grid to 1440px, so a card's window is now 320 by 233. The scenes still rendered at 376 by 275 and scaled down to fit. Each drew about 39% more pixels than its window shows, and Dither and LED Wall showed their cells at 0.85 of their real size. SCENE_SIZE and the card loop in build-posters.sh now use 320 by 233, and the seven card posters are recaptured at that size. homepage.spec.ts checks the posters' new shape. favorites-hover.spec.ts checks that at 1728px a scene renders at its window's size, with a scale of 1.
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scene, capture, asset, and regression-test dimensions are consistently aligned.
0 open findings
What changed in this PR
Aligns favorite-card live scenes and posters with the 1440px grid to avoid unnecessary rendering and scaling.
Changes:
- Resizes scenes and poster captures to 320×233.
- Recaptures all seven card posters.
- Adds Playwright coverage for poster aspect ratio and scene scaling.
| File | Description |
|---|---|
scripts/build-posters.sh |
Updates card-poster capture dimensions. |
apps/docs/src/components/favorites/favorites-list.tsx |
Sets the live-scene size to 320×233. |
apps/docs-tests/docs/homepage.spec.ts |
Checks the new poster aspect ratio. |
apps/docs-tests/docs/favorites-hover.spec.ts |
Verifies scene and window dimensions at full grid width. |
apps/docs/public/posters/dither-card.jpg |
Recaptured card poster. |
apps/docs/public/posters/god-rays-card.jpg |
Recaptured card poster. |
apps/docs/public/posters/led-wall-card.jpg |
Recaptured card poster. |
apps/docs/public/posters/mesh-gradient-card.jpg |
Recaptured card poster. |
apps/docs/public/posters/simplex-noise-card.png |
Recaptured card poster. |
apps/docs/public/posters/voronoi-card.jpg |
Recaptured card poster. |
apps/docs/public/posters/wave-lines-card.jpg |
Recaptured card poster. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hunterbecton
deleted the
hunter/sha-220-resize-the-favorites-scenes-and-card-posters-to-the-1440px
branch
October 9, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SHA-218 narrowed the favorites grid to 1440px, so a card's window is now 320 by 233 at full width. The live scenes still rendered at 376 by 275 and scaled down to fit. Each drew about 39% more pixels than its window shows, and Dither and LED Wall showed their cells at 0.85 of their real size. SHA-220.
What changes
The scene and poster size
SCENE_SIZEinfavorites-list.tsxis now 320 by 233, so at full widthuseCoverScaleleaves each scene at a scale of 1. The card loop inscripts/build-posters.shcaptures at the same size, and the seven card posters are recaptured with it, so each poster still frames and crops its scene the way the live canvas does. Only the card loop ran, so the other posters are unchanged.Specs
homepage.spec.tschecks the posters' new shape. A new test infavorites-hover.spec.tshovers a favorite at the mock's 1728px and checks that its scene matches its window, with a scale of 1. At the old size it failed with a scale of 0.851.Known limitations
The two-column and one-column grids give a window larger than 320 by 233 at their wider widths, so the scene scales up there, as far as 1.8 times at 639px. It scaled up there before this change too, by less. The
SCENE_SIZEcomment documents this.