Repository navigation
Show GitHub approval and bot reviews by default - #73
Merged
Merged
Conversation
The cell fell back to reviewDecision only when no reviews were listed. Pending reviewer requests and the bot display filter therefore masked an APPROVED decision, so a Copilot approval read as pending or blank. GitHub decision now wins unless a visible review requests changes, and an approval given only by a hidden bot reads "approved (bot)".
reviews.show_bots now defaults to true so bot reviewers such as Copilot appear without pressing b. Set show_bots = false to restore the old behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copilot approvals did not turn the Reviews cell green. Two causes:
review_labelused GitHub'sreviewDecisiononly when the PR had no listed reviews. Pending reviewer requests and the bot filter masked anAPPROVEDdecision, so the cell showed◷ pending. GitHub's decision now wins unless a visible review requests changes. An approval given only by a hidden bot reads✔ approved (bot).reviews.show_botsnow defaults totrue, so bot reviewers such as Copilot are listed without pressingb. Setshow_bots = falseto restore the old behavior. Thebtoggle is unchanged.Observed on gopro/infra-katalyst-platform#2297:
reviewDecision: APPROVED, bot approvercopilot-pull-request-reviewer, two pending human requests.Testing
cargo fmt --all -- --check: passes (make preflight)cargo clippy --workspace --all-targets --locked -- -D warnings: passes (make preflight)cargo test --workspace --locked --no-fail-fast: passes (make preflight). The new testgithub_approval_by_a_hidden_bot_is_not_masked_by_pending_requestsfailed without the fix. Three tests that pinned the old default (keymap.rsx2,render.rs) were rewritten to assert default-visible bots and the toggle hiding them.make demo: N/A because the demo stack has no bot-approved PR and my PTY capture ofmake demoreturned no text. The render contract is covered byTestBackendtests.Docs and architecture
cargo doc --workspace --no-deps --locked: passes; the newDefaultimpl and field are documentedNotes for reviewers
show_bots = false.