-
Notifications
You must be signed in to change notification settings - Fork 0
fix: native host setup scripts #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@calycode/cli": patch | ||
| --- | ||
|
|
||
| fix: improve native host setup reliability |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| *.bat text eol=crlf |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| #!/bin/bash | ||
| # Unix/macOS installer entrypoint. | ||
| # Delegates to the existing shared installer implementation. | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
|
|
||
| exec "${SCRIPT_DIR}/install.sh" "$@" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| @echo off | ||
| REM Windows installer entrypoint. | ||
| REM Delegates to existing shared batch installer implementation. | ||
|
|
||
| setlocal | ||
| set "SCRIPT_DIR=%~dp0" | ||
|
|
||
| call "%SCRIPT_DIR%install.bat" %* | ||
| exit /b %ERRORLEVEL% | ||
|
Comment on lines
+1
to
+9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use CRLF line endings for this batch entrypoint. This file is committed with LF-only endings; 🧰 Tools🪛 Blinter (1.0.112)[error] 1-1: Unix line endings detected. Explanation: Batch file uses Unix line endings (LF-only) which can cause GOTO/CALL label parsing failures and script malfunction due to Windows batch parser 512-byte boundary bugs. Recommendation: Convert file to Windows line endings (CRLF). Use tools like dos2unix, notepad++, or configure git with 'git config core.autocrlf true'. Context: File uses Unix line endings (LF-only) - 9 LF sequences found (E018) 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #Requires -Version 5.1 | ||
| <# | ||
| .SYNOPSIS | ||
| Windows installer entrypoint. | ||
|
|
||
| .DESCRIPTION | ||
| Delegates to the existing shared PowerShell installer implementation (install.ps1). | ||
| #> | ||
|
|
||
| [CmdletBinding()] | ||
| param( | ||
| [Parameter(ValueFromRemainingArguments = $true)] | ||
| [string[]]$Args | ||
| ) | ||
|
|
||
| $ErrorActionPreference = 'Stop' | ||
|
|
||
| $scriptDir = Split-Path -Parent $MyInvocation.MyCommand.Path | ||
| $target = Join-Path $scriptDir 'install.ps1' | ||
|
|
||
| & $target @Args | ||
| exit $LASTEXITCODE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix env-var example so variables reach the installer process.
The current example sets
CALYCODE_VERSION/CALYCODE_SKIP_NATIVE_HOSToncurl, not onbash, so the installer won’t read them.Suggested doc fix
📝 Committable suggestion
🤖 Prompt for AI Agents