Refactor C++ loader: extract cache and addon registry, resolve TODOs#104

Open

mani3xis wants to merge 55 commits into

mainfrom

mario/wip-refactor-cpp

Commits on Jun 17, 2025

feat(babel): add 2 params to requireNodeAddon(); respect package entrypoints
Mariusz Pasinski
committed
refactor: extract `findNodeAddonForBindings()`
Mariusz Pasinski
committed
feat: add shortcut to `isNodeApiModule()`
Mariusz Pasinski
committed
feat: relax the condition for CJS modules without file exts
Mariusz Pasinski
committed
style: address linter issues
Mariusz Pasinski
committed
feat: extract path normalization from `determineModuleContext()`
Mariusz Pasinski
committed
feat: update tests to cover `determineNormalizedModuleContext()`
Mariusz Pasinski
committed
feat: add test for scoped package names
Mariusz Pasinski
committed
feat: update tests for 3 arg `requireNodeAddon()`
Mariusz Pasinski
committed
feat: remove xcframework dir from test code
Mariusz Pasinski
committed
feat: change the third param to original path
Mariusz Pasinski
committed
feat: add test case for require with "main" entry point
Mariusz Pasinski
committed
fix: remove unused `requiredFrom` parameter
Mariusz Pasinski
committed
fix: remove unsupported babel option "naming"
Mariusz Pasinski
committed
feat: add tests for `findNodeAddonsForBindings()`
Mariusz Pasinski
committed
fix: ensure that module paths use only forward slash (esp. on Windows)
Mariusz Pasinski
committed
feat: add test case for addon that "escaped" its package
Mariusz Pasinski
committed
feat: make `resolvedPath` optional as suggested by Kraen
Mariusz Pasinski
committed
feat: run each test case as separate call to `it()`
Mariusz Pasinski
committed
chore: move `findNodeAddonForBindings()` to path-utils
Mariusz Pasinski
committed
chore: rename `originalPath` parameter to `originalId`
Mariusz Pasinski
committed
chore: replace `[].forEach()` with for-of
Mariusz Pasinski
committed
feat: move path slash normalization to determineModuleContext()
Mariusz Pasinski
committed
chore: use more descriptive variable names
Mariusz Pasinski
committed
feat: make requireNodeAddon() take 3 arguments
Mariusz Pasinski
committed
fixup: remove single argument requireNodeAddon()
Mariusz Pasinski
committed
feat: add path utility functions
Mariusz Pasinski
committed
feat: ensure that paths use safe ASCII alphanumericals
Mariusz Pasinski
committed
feat: declare alias for custom resolver function
Mariusz Pasinski
committed
feat: add support for custom prefix resolvers
Mariusz Pasinski
committed
feat: add support for custom package-specific resolvers
Mariusz Pasinski
committed
refactor: extract existing loading code to resolveRelativePath() method
Mariusz Pasinski
committed
feat: add `startsWith()` helper function
Mariusz Pasinski
committed
feat: compute merged subpath and verify it before loading
Mariusz Pasinski
committed
fix: explicitly cast `pathPrefix` to `std::string` for lookup
Mariusz Pasinski
committed
fix: ensure `joinPath` is called on `requiredFrom`'s parent directory
Mariusz Pasinski
committed
feat: add stub methods for interacting with require cache
Mariusz Pasinski
committed
feat: make the `resolveRelativePath()` interact with (no-op) require cache
Mariusz Pasinski
committed
feat: draft first implementation of AddonRegistry
Mariusz Pasinski
committed
refactor: swap old TM addon loader with AddonRegistry
Mariusz Pasinski
committed
feat: support modules that register via `napi_module_register()`
Mariusz Pasinski
committed
fixup: update params in NativeNodeApiHost spec
Mariusz Pasinski
committed
fix: implement proper extension stripping
Mariusz Pasinski
committed

Commits on Jun 18, 2025

feat: extract the "twisted" node api addon example from "wip-refactor-cpp"
Mariusz Pasinski
committed
fix: include the generated (and corrected) CMakeList
Mariusz Pasinski
committed
chore: rename `requiredFrom` param to `originalId`
Mariusz Pasinski
committed
fixup: fix types in `endsWith` (use `string_views`)
Mariusz Pasinski
committed
fix: change param types of `startsWith` to `string_view`s
Mariusz Pasinski
committed
Merge branch 'mario/twisted-addon-example' into mario/wip-refactor-cpp
Mariusz Pasinski
committed
feat: add `2_function_arguments_twisted/napi` to list of examples
Mariusz Pasinski
committed
fix: defer calling `napi_module_register()` until weak node api injection
Mariusz Pasinski
committed

Commits on Jun 20, 2025

hack: apply workaround for "twisted" addon
Mariusz Pasinski
committed
refactor: remove unused path utils
Mariusz Pasinski
committed
fix: assertion firing when loading deprecated way
Mariusz Pasinski
committed
chore: remove redundant feature flag
Mariusz Pasinski
committed