fix: keep only one reference of xcframeworks when spm enabled#364
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes duplicated .xcframework artifacts when generating a local Swift Package Manager package (--add-spm-package) by moving XCFrameworks into spm-artifacts instead of copying them, so only a single set of artifacts remains.
Changes:
- Switch XCFramework handling from copy (
fs.cpSync) to move (fs.renameSync) during SPM artifact preparation. - Update generated README guidance to match the new
spm-artifacts/layout. - Update unit tests to assert the source
.xcframeworkdirectories are removed after SPM preparation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/cli/src/brownfield/utils/prepareLocalSpmArtifacts.ts | Moves XCFrameworks into spm-artifacts to eliminate duplicate artifact copies. |
| packages/cli/src/brownfield/utils/createLocalSpmPackage.ts | Updates README instructions to refer to the spm-artifacts directory. |
| packages/cli/src/brownfield/utils/tests/prepareLocalSpmArtifacts.test.ts | Updates assertions to verify XCFrameworks are moved (source removed) and signatures normalized. |
| packages/cli/src/brownfield/utils/tests/createLocalSpmPackage.test.ts | Updates assertions to verify the original XCFramework path no longer exists after package creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the duplicate xcframeworks being generated when
--add-spm-packageis enabled. With this option, we see one instance of xcframeworks underspm-artifactsand other underpackage/build.Test plan
Before:
After: