-
Notifications
You must be signed in to change notification settings - Fork 40
feat: add example Rock app #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Juozas-Petkelis
wants to merge
15
commits into
callstack:main
Choose a base branch
from
Juozas-Petkelis:feat/rock-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7,926
−538
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1a15e66
feat: add rock app
Juozas-Petkelis dca03cd
feat: rename rockappreact to brownfieldlib
Juozas-Petkelis 537cc1f
feat: update rock template to RN 85
Juozas-Petkelis 88a0966
feat: add rock app to prepare framework script
Juozas-Petkelis 091d8ed
feat: prepare frameworks for rock app
Juozas-Petkelis 7d9a760
feat: extract shared UI for vanilla and rock app
Juozas-Petkelis 08dd18c
feat: added rock actions
Juozas-Petkelis adb1680
feat: added rock cli commands to readme
Juozas-Petkelis bfe7449
feat: home screen adjustments
Juozas-Petkelis e0b2e92
fix: revert generated brownfield navigation files
Juozas-Petkelis 7c3207d
fix: remove embed rock frameworks workaround
Juozas-Petkelis 13a78d8
fix: add separate scheme for Vanilla and Rock
Juozas-Petkelis 684db6b
fix: adjust appleApp project.pbxproj for rock
Juozas-Petkelis 2e8ae49
feat: add RockApp as hostAppName to ContentView pragma
Juozas-Petkelis f6ac72b
chore: update yarn.lock
Juozas-Petkelis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
.../AndroidApp/app/src/rock/java/com/callstack/brownfield/android/example/BrownfieldStore.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| package com.callstack.brownfield.android.example | ||
|
|
||
| typealias BrownfieldStore = com.callstack.rnbrownfield.demo.rockapp.BrownfieldStore | ||
| typealias User = com.callstack.rnbrownfield.demo.rockapp.User |
6 changes: 6 additions & 0 deletions
6
...oidApp/app/src/rock/java/com/callstack/brownfield/android/example/ReactNativeConstants.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package com.callstack.brownfield.android.example | ||
|
|
||
| object ReactNativeConstants { | ||
| const val MAIN_MODULE_NAME = "RockApp" | ||
| const val APP_NAME = "Android" | ||
| } |
9 changes: 9 additions & 0 deletions
9
...dApp/app/src/rock/java/com/callstack/brownfield/android/example/ReactNativeHostManager.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.callstack.brownfield.android.example | ||
|
|
||
| import android.content.res.Configuration | ||
|
|
||
| typealias ReactNativeHostManager = com.callstack.rnbrownfield.demo.rockapp.ReactNativeHostManager | ||
|
|
||
| fun ReactNativeHostManager.onConfigurationChanged(application: android.app.Application, newConfig: Configuration) { | ||
| // no-op that is prepared to match of the Expo ReactNativeHostManager | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.