Skip to content

⚡ Bolt: Optimize content-type prefix matching to avoid allocation - #329

Open
callmeradical wants to merge 1 commit into
mainfrom
bolt/avoid-strings-tolower-3591243859574229893
Open

callmeradical wants to merge 1 commit into
mainfrom
bolt/avoid-strings-tolower-3591243859574229893

Conversation

@callmeradical

Copy link
Copy Markdown
Owner

💡 What: Replaced strings.HasPrefix(strings.ToLower(resp.contentType), "text/event-stream") with a zero-allocation approach using strings.EqualFold.
🎯 Why: strings.ToLower forces a memory allocation on the hot path of handling every HTTP response in the proxy. By using slicing and strings.EqualFold, we achieve the same case-insensitive prefix matching without allocating memory.
📊 Impact: Eliminates a memory allocation per proxy response, reducing GC pressure and improving latency.
🔬 Measurement: Review the code to verify the elimination of strings.ToLower, and run go test ./... to ensure correctness.


PR created automatically by Jules for task 3591243859574229893 started by @callmeradical

Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant