Repository navigation
⚡ Bolt: Eliminate strings.ToLower allocation in content-type parsing - #322
callmeradical wants to merge 1 commit into
Conversation
Replaced strings.ToLower combined with strings.HasPrefix with strings.EqualFold for zero-allocation content-type matching in proxy.go. Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced strings.ToLower combined with strings.HasPrefix with strings.EqualFold for content-type prefix matching in the proxy hot path.
🎯 Why: Using strings.ToLower allocates a new string on every response, increasing garbage collection pressure. This change eliminates the allocation while maintaining case-insensitive header matching.
📊 Impact: Zero memory allocations for checking if the response is an event stream, slightly improving proxy throughput and reducing GC overhead on high-frequency requests.
🔬 Measurement: Verified by running the standard Go test suite to ensure no regressions in SSE or standard response handling.
PR created automatically by Jules for task 2583815159652146506 started by @callmeradical