⚡ Bolt: Zero-allocation case-insensitive prefix matching - #320
callmeradical wants to merge 1 commit into
Conversation
Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
strings.ToLowerwithstrings.EqualFoldfor case-insensitive prefix matching on the content type header incmd/sergeant-mcp-client/proxy.go.🎯 Why:
strings.ToLowerforces a memory allocation when checking if a string starts with a specific prefix. In hot paths (like processing HTTP responses), this creates unnecessary GC pressure.strings.EqualFoldachieves the same result with zero allocations.📊 Impact: Eliminates a memory allocation per proxy response when checking for the
text/event-streamcontent type, slightly reducing GC overhead.🔬 Measurement: A Go micro-benchmark comparing
strings.HasPrefix(strings.ToLower(s), prefix)vslen(s) >= len(prefix) && strings.EqualFold(s[:len(prefix)], prefix)would show 0 allocations for the latter.PR created automatically by Jules for task 929279684384335444 started by @callmeradical