Skip to content

⚡ Bolt: Zero-allocation case-insensitive prefix matching - #320

Open
callmeradical wants to merge 1 commit into
mainfrom
bolt/zero-alloc-case-insensitive-prefix-matching-929279684384335444
Open

callmeradical wants to merge 1 commit into
mainfrom
bolt/zero-alloc-case-insensitive-prefix-matching-929279684384335444

Conversation

@callmeradical

Copy link
Copy Markdown
Owner

💡 What: Replaced strings.ToLower with strings.EqualFold for case-insensitive prefix matching on the content type header in cmd/sergeant-mcp-client/proxy.go.
🎯 Why: strings.ToLower forces a memory allocation when checking if a string starts with a specific prefix. In hot paths (like processing HTTP responses), this creates unnecessary GC pressure. strings.EqualFold achieves the same result with zero allocations.
📊 Impact: Eliminates a memory allocation per proxy response when checking for the text/event-stream content type, slightly reducing GC overhead.
🔬 Measurement: A Go micro-benchmark comparing strings.HasPrefix(strings.ToLower(s), prefix) vs len(s) >= len(prefix) && strings.EqualFold(s[:len(prefix)], prefix) would show 0 allocations for the latter.


PR created automatically by Jules for task 929279684384335444 started by @callmeradical

Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant