Repository navigation
⚡ Bolt: Avoid strings.ToLower allocation in proxy HTTP header matching - #319
callmeradical wants to merge 1 commit into
Conversation
Replaced `strings.ToLower` combined with `strings.HasPrefix` with a zero-allocation approach using `strings.EqualFold` and slicing for matching the `text/event-stream` header in the proxy. Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
strings.ToLowerin combination withstrings.HasPrefixwith a zero-allocation approach usingstrings.EqualFoldand slicing for matching thetext/event-streamheader in the proxy.🎯 Why:
strings.ToLowerforces a memory allocation and creates garbage collection pressure in hot paths (like processing HTTP responses in the proxy).📊 Impact: Eliminates a memory allocation per proxy HTTP response containing a
text/event-streamor similar content type header, reducing GC pressure and marginally improving throughput.🔬 Measurement: Verified correctness by running
go test ./...to ensure header matching semantics remain identical.PR created automatically by Jules for task 13362341045440475811 started by @callmeradical