Skip to content

⚡ Bolt: Avoid strings.ToLower allocation in proxy HTTP header matching - #319

Open
callmeradical wants to merge 1 commit into
mainfrom
bolt/optimize-header-matching-13362341045440475811
Open

callmeradical wants to merge 1 commit into
mainfrom
bolt/optimize-header-matching-13362341045440475811

Conversation

@callmeradical

Copy link
Copy Markdown
Owner

💡 What: Replaced strings.ToLower in combination with strings.HasPrefix with a zero-allocation approach using strings.EqualFold and slicing for matching the text/event-stream header in the proxy.
🎯 Why: strings.ToLower forces a memory allocation and creates garbage collection pressure in hot paths (like processing HTTP responses in the proxy).
📊 Impact: Eliminates a memory allocation per proxy HTTP response containing a text/event-stream or similar content type header, reducing GC pressure and marginally improving throughput.
🔬 Measurement: Verified correctness by running go test ./... to ensure header matching semantics remain identical.


PR created automatically by Jules for task 13362341045440475811 started by @callmeradical

Replaced `strings.ToLower` combined with `strings.HasPrefix` with a zero-allocation approach using `strings.EqualFold` and slicing for matching the `text/event-stream` header in the proxy.

Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant