Repository navigation
⚡ Bolt: Avoid strings.ToLower in proxy response header matching - #318
callmeradical wants to merge 1 commit into
Conversation
Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
strings.HasPrefix(strings.ToLower(...), ...)with a zero-allocation prefix match usinglen(...) >= len(...) && strings.EqualFold(...).🎯 Why: The original code used
strings.ToLowerin a hot path when proxying responses, which forced a memory allocation for every parsed HTTP response.📊 Impact: Eliminates a memory allocation per proxy response, reducing garbage collection pressure and improving performance for high-throughput responses.
🔬 Measurement: Profiling heap allocations (
go test -bench . -benchmem) will show a reduction in allocations per operation in the proxy loop.PR created automatically by Jules for task 6651251117106882050 started by @callmeradical