feat(mobile): set home location#79
Draft
cafca wants to merge 11 commits into
Draft
Conversation
Adds a test that overrides homeLocationProvider with a throwing controller, taps an Alexanderplatz result, and asserts the "Couldn't set home" SnackBar is shown while SearchScreen stays visible.
Add a `_saving` boolean flag to `_SearchScreenState` that short-circuits `_selectLocation` on re-entry while a save is in-flight, preventing a rapid double-tap from calling `homeLocationProvider.save()` twice. Reset `_saving` only on the error path; the success path pops the screen so no reset is needed. Includes a regression test with a slow-save stub.
cafca
force-pushed
the
claude/objective-liskov-362609
branch
from
3feda3d to
24f7fb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SearchScreenvia newSearchMode.pickHome— picker pops with the savedLocation, caller shows snackbar.homeLocationProvider.save()already existed).Spec: docs/superpowers/specs/2026-04-26-mobile-set-home-design.md
Plan: docs/superpowers/plans/2026-04-26-mobile-set-home.md
Test plan
just test-mobile— 196 tests green,flutter analyzecleanjust dev-ios-sim):