fix: forward extra kwargs from create_node to node_class - #249
Open
Sanjays2402 wants to merge 1 commit into
Open
fix: forward extra kwargs from create_node to node_class#249Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
Tree.create_node() only passed tag/identifier/data to the tree's node_class, so the custom-Node example in the docs raised TypeError: create_node() got an unexpected keyword argument 'size'. Extra keyword arguments are now forwarded to the node_class constructor, and the docs example accepts/forwards **kwargs so the Node base still receives data/expanded. Fixes caesar0301#240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #240
The
Custom Node Classesdocs example fails withTypeError: create_node() got an unexpected keyword argument 'size':Tree.create_node()only forwardstag/identifier/datatoself.node_class, so a Node subclass with extra constructor arguments is unusable through the documented API. Extra keyword arguments are now forwarded to the node class, and the docs example takes/forwards**kwargsso theNodebase still receivesdata/expanded.Regression test added beside
test_subclassingintests/test_tree.py; it fails withTypeErrorwithout the change and passes with it (fulltests/test_tree.py: 74 passed).This change was prepared with AI assistance; the regression test was run locally and fails without the fix.