Added from_json() function and also added option to add identifier in… - #244
Merged
liamlundy merged 3 commits intoJul 23, 2026
Merged
Conversation
cmoliverio
force-pushed
the
optional_identifier_and_from_json
branch
from
July 1, 2026 17:26
06e0ca4 to
700d9d7
Compare
This was referenced Jul 1, 2026
Author
|
Can this get merged? |
cmoliverio
force-pushed
the
optional_identifier_and_from_json
branch
from
July 8, 2026 22:50
afc6032 to
38de0e9
Compare
Author
|
@liamlundy Tests from @dgercho incorporated. Done. |
liamlundy
approved these changes
Jul 9, 2026
Author
|
@caesar0301 Can you merge this pls? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves backwards compatibility issue in #239 by making the identifier and option in the
to_dict()andto_json()functions. Also, added the class methodfrom_json().@liamlundy I didn't write any tests for this specifically for this, but it shouldn't be necessary since this is an optional feature. Let me know if you want tests though, and if you want more tests for
to_dict()andto_json().