Repository navigation
Require an attached file to be cited, not merely checked - #38
Merged
Merged
Conversation
Eighteen files were attached to one packet and the review referenced none of them. Two causes, and both were real. The policies asked the reviewer to check a claim against an attachment and to cite a path when the two disagreed. They never asked it to name the file otherwise, so a finding about attached code could be written without a path at all. Every policy now requires the path whenever a finding concerns an attached file, requires the settling line to be quoted where an attachment settles a question, and forbids asserting anything about a file whose contents were not read. The measurement was also wrong. References were matched against the released text, and a withheld or unselected candidate releases the fixed terminal response, so that match could find nothing however thoroughly the reviewer had cited its attachments. It now reads what the reviewer actually wrote. A review that references none of its attachments now reads in amber and says so plainly. Files sent and never used are files that did no work, and that belongs on the screen as a problem rather than as a neutral observation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxxEQsJEXq9hZmjpNH5PxY
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eighteen files attached to one packet, and the review referenced none of them. Two causes, both real.
The policies never asked for the path
They required the reviewer to check a claim against an attachment, and to cite a path when the two disagreed. Nothing asked it to name the file otherwise — so a finding about attached code could be written with no path at all, which is exactly what happened.
Added to all four policies:
The last clause matters as much as the first: this asks for grounding, not decoration. A file with no bearing on the decision still needn't be mentioned.
The measurement was also wrong
References were matched against the released text. A withheld or unselected candidate releases
Bob Regress, so that match could find nothing however thoroughly the reviewer had cited its attachments. It now reads what the reviewer actually wrote.Ungrounded reviews now look like a problem
None are referencedwas a neutral grey note. Files sent and never used are files that did no work, so it now reads in amber and says so:FileEvidencecarries a level —used,partial,unused,none— and the card is styled from it.Tests
Bob Regressalone finds 0, plus the reviewer's own words finds 2used, some →partial, none →unused, no attachments →none121 unit tests (120 pass / 1 Windows-only skip), mocked e2e, lint, build clean, browser check at 390×844.
What to expect
The policy change only affects packets sent after you deploy. Reviews already in history keep their existing text — the card will now read them correctly, but it can't add citations that were never written.
Generated by Claude Code