fix: add --ignore-missing-version flag for glob patterns#282
Open
maimul wants to merge 1 commit into
Open
Conversation
When using glob patterns, some matched files may not contain the version string. Previously bumpversion would crash with VersionNotFoundException for any such file. This adds --ignore-missing-version (also settable via ignore_missing_version = True in config) which logs a warning and skips files that don't contain the expected version string. Fixes c4urself#267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using glob patterns in
[bumpversion:glob:...]sections, some matched files may not contain the version string. bumpversion currently raisesVersionNotFoundExceptionand aborts — there's no way to say "skip files that don't have the version".Fix
--ignore-missing-versionCLI flagignore_missing_versionboolean to the config-file boolean-parsing loop (so it can be set persistently in.bumpversion.cfg)VersionNotFoundExceptionincli.py(it was only used inutils.py)_check_files_contain_versionto catch the exception and log a warning instead of re-raising when the flag is setUsage
Or in config:
Fixes #267