fix(install): list libusrsctp in cwist.pc when WebRTC is built - #315
Merged
Merged
Conversation
make install copies libusrsctp.a into the deps directory, but cwist.pc never named it, so a program using the WebRTC API through pkg-config failed to link (undefined usrsctp_* from sctp.o). Programs that do not touch WebRTC were unaffected: the archive member is never pulled in. Also remove libusrsctp.a on uninstall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make installcopieslibusrsctp.aintolib/cwist/, butcwist.pcnever listed it. A program that uses the WebRTC API and links throughpkg-config --libs cwist(including Homebrew installs) fails with undefinedusrsctp_*symbols. Programs that don't use WebRTC were unaffected.CWIST_WEBRTC=1,Libs:now includes-lusrsctpright after-lcwist. WithCWIST_WEBRTC=0, the output is unchanged.uninstallnow also removeslibusrsctp.a.Checked:
make installinto a temp prefix, then a program that callscwist_webrtc_ctx_new()links via pkg-config and runs. It failed before the fix.