feat: Smart/Origin: ffcam livraison1#2205
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Documentation | 1 minor |
🟢 Metrics 19 complexity · 2 duplication
Metric Results Complexity 19 Duplication 2
🟢 Coverage 94.80% diff coverage · +0.18% coverage variation
Metric Results Coverage variation ✅ +0.18% coverage variation Diff coverage ✅ 94.80% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (6696cad) 21824 20126 92.22% Head commit (ebaab6d) 21972 (+148) 20303 (+177) 92.40% (+0.18%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#2205) 173 164 94.80% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
(cherry picked from commit 93bebb80fdb59d386ceef810b2adec13521ce962)
Nayor
left a comment
Nayor
left a comment
There was a problem hiding this comment.
OK pour moi, juste 2 petits détail pour faciliter l'exploitation
| elif not response.ok: | ||
| raise HTTPInternalServerError( | ||
| "Navitia API error: %d " % response.status_code | ||
| "unknown_error" |
There was a problem hiding this comment.
Il faudrait logger l'erreur quelque part non ?
Sinon ça va être impossible à débugger
| if response.status_code == 401: | ||
| raise HTTPInternalServerError("Authentication error with Navitia API") | ||
| if response.status_code == 400: | ||
| raise HTTPBadRequest("invalid_param") |
There was a problem hiding this comment.
Idem, mettre le message d'erreur de la réponse pour mieux débugger
3 participants
Details: