Skip to content

test(renderer): explicit budgets for the remaining full-App edge tests - #534

Merged
PeterGuy326 merged 1 commit into
mainfrom
fix/529-reanchors-test-timeout
Sep 29, 2026
Merged

PeterGuy326 merged 1 commit into
mainfrom
fix/529-reanchors-test-timeout

Conversation

@PeterGuy326

Copy link
Copy Markdown
Contributor

Preflight

Summary

After the toolbar test got its explicit 15s budget (#531), the next-slowest tests surfaced at the 5s vitest default on macOS runners. This gives the three observed edge-dwellers the same explicit 15s budget the other heavy tests in these files already carry:

Test Observed timeouts
App.test.tsx > reanchors a repeated project turn link… 4 consecutive runs across #527/#522/#513 (deterministic on macOS)
App.test.tsx > binds the ready %s runtime in HireDrawer… 1 run (#522, job 109243787847)
docs-lifecycle.test.tsx > preserves undo and redo history… 1 run (#522, job 109243787847)

No production code changes; test files only.

Evidence

  • All three failures are Test timed out in 5000ms (job logs 109243787847, 109247014992, 109247113086), each followed by a green rerun or a pass on the other platform — the signature of cold, heavy tests at the 5s edge under runner load, not hangs.
  • The reanchors case timed out on every macOS run observed today (4/4), so it sits furthest above the default.

Assumptions

Acceptance

  • Node 24 / ubuntu-latest and Node 24 / macos-14 pass on this PR and on fresh runs of main after merge.
  • No production code change: test files only.

Refs #529, #531

After the toolbar test got its 15s budget (#531), the next-slowest
full-App tests surfaced at the 5s edge on macOS runners: the turn-link
re-anchor test timed out on four consecutive runs across #527/#522/#513,
and the HireDrawer binding and docs undo/redo tests each timed out once
under the same runner load. Give all three the same explicit 15s budget
the other heavy tests in these files already carry.
@PeterGuy326
PeterGuy326 merged commit 97656cd into main Sep 29, 2026
11 checks passed
PeterGuy326 added a commit that referenced this pull request Sep 29, 2026
…ation (#527)

Bindy-lbb approved the content diff (APPROVED on 4ac32a2). This squash only syncs the branch with main after the #531/#534 CI-budget fixes landed.
PeterGuy326 pushed a commit that referenced this pull request Sep 29, 2026
Migrates native selects to the shared Select facade; tests aligned and busy-state preserved. The reviewer CHANGES_REQUESTED on b071b54 (macos-14 toolbar-test timeout) was resolved by the #531/#534 explicit test budgets; branch synced with main and all required checks green before merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant