Repository navigation
fix(deps): clear the fast-uri high advisory that fails the npm audit gate - #530
Merged
Merged
Conversation
fast-uri 3.1.6 -> 3.1.8 clears GHSA-qw65-cvwx-89v3 and GHSA-58mr-gqgx-xq4g (high); undici 6.28.0 -> 6.29.0 and 7.29.0 -> 7.30.0 clear GHSA-3wwx-pv8p-q78v (moderate). Lockfile-only via npm audit fix --package-lock-only: no manifest range changes and no breaking bump, so the verify security gate passes without forcing the vitest 5 upgrade.
Bindy-lbb
approved these changes
Sep 29, 2026
Bindy-lbb
left a comment
Collaborator
There was a problem hiding this comment.
复审通过:改动仅涉及 package-lock.json 中 fast-uri 3.1.8 与 undici 6.29.0/7.30.0 三个条目;package.json 未变,锁定版本符合对应依赖范围并高于 GHSA 公告中的修复版本,registry integrity 也匹配。当前 verify、Dependency review、CodeQL 等检查全绿。
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preflight
main@f2fca7b; the only change ispackage-lock.json.Summary
verifyfails on main becausenpm run security:check(npm audit --audit-level=high) exits 1 on the fast-uri high advisory (#528). Lockfile-only, non-breaking bumps:Produced with
npm audit fix --package-lock-only; no manifest range changed, no breaking bump taken, node_modules untouched.Evidence
npm audit --audit-level=high --package-lock-onlyreports 4 vulnerabilities (1 high, 3 moderate) and exits 1 onmain@f2fca7b.@vitest/mockerchain that requires vitest 5) and exits 0, so the--audit-level=highgate passes.Assumptions
--audit-level=highis meant to block high and critical only; the remaining moderates do not fail the gate. If the gate should be moderate-clean too, that is the vitest 5 upgrade discussed in fix(ci): verify fails on the fast-uri high advisory in npm audit #528 — breaking, deliberately not taken here.App.test.tsxtoolbar-timeout signature of ci(renderer): App context navigation toolbar test times out on fresh runs of main (both platforms) #529 on this PR's runs are unrelated to this change (lockfile-only); they reproduce on fresh runs ofmainitself.Acceptance
npm run security:checkpasses on CI (the verify workflow's audit gate).package.jsonchange: lockfile-only, semver-compatible bumps; install/build behavior unchanged.Closes #528