Skip to content

fix(projects): pin the schedule bar spec clock so clamping stays calendar-independent #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waterbro-8 wants to merge 1 commit into from
Closed

fix(projects): pin the schedule bar spec clock so clamping stays calendar-independent #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 60 additions & 51 deletions apps/desktop/renderer/test/project-board.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,58 +559,67 @@ describe("ProjectBoard", () => {
});

it("clamps schedule bar calculations for inverted dates, window-edge spans, and partially invalid dates", () => {
setup(
detail([
{
...task,
taskId: "inverted-task",
title: "Inverted dates task",
startDate: "2026-09-28",
dueDate: "2026-09-22",
},
{
...task,
taskId: "span-task",
title: "Span task across window",
startDate: "2025-01-01",
dueDate: "2027-01-01",
},
{
...task,
taskId: "partial-date-task",
title: "Partially invalid date task",
startDate: "malformed-date",
dueDate: "2026-09-22",
},
]),
);

fireEvent.click(screen.getByRole("button", { name: "排期" }));
// The schedule window starts at the Monday of the current week
// (ProjectBoard.tsx:95), so these fixed fixtures only stay inside it for a
// finite calendar span. Pin the clock to keep the clamping math deterministic.
vi.useFakeTimers({ toFake: ["Date"] });
vi.setSystemTime(new Date("2026-09-24T12:00:00.000Z"));
try {
setup(
detail([
{
...task,
taskId: "inverted-task",
title: "Inverted dates task",
startDate: "2026-09-28",
dueDate: "2026-09-22",
},
{
...task,
taskId: "span-task",
title: "Span task across window",
startDate: "2025-01-01",
dueDate: "2027-01-01",
},
{
...task,
taskId: "partial-date-task",
title: "Partially invalid date task",
startDate: "malformed-date",
dueDate: "2026-09-22",
},
]),
);

// Inverted task bar is clamped chronologically without negative width
const invBar = screen.getByRole("button", { name: /^Inverted dates task: / });
expect(invBar).toBeInTheDocument();
const invLeft = parseFloat(invBar.style.left.match(/([\d.]+)%/)![1]);
const invWidth = parseFloat(invBar.style.width.match(/([\d.]+)%/)![1]);
expect(invLeft).toBeGreaterThanOrEqual(0);
expect(invWidth).toBeGreaterThan(0);

// Span task covering beyond the window boundaries is clamped to [0%, 100%]
const spanBar = screen.getByRole("button", { name: /^Span task across window: / });
expect(spanBar).toBeInTheDocument();
expect(spanBar.style.left).toBe("0%");
expect(spanBar.style.width).toBe("100%");

// Partially invalid date task uses the valid date safely without NaN
const partialBar = screen.getByRole("button", { name: /^Partially invalid date task: / });
expect(partialBar).toBeInTheDocument();
const partialLeft = parseFloat(partialBar.style.left.match(/([\d.]+)%/)![1]);
const partialWidth = parseFloat(partialBar.style.width.match(/([\d.]+)%/)![1]);
expect(Number.isFinite(partialLeft)).toBe(true);
expect(Number.isFinite(partialWidth)).toBe(true);
expect(partialLeft).toBeGreaterThanOrEqual(0);
expect(partialWidth).toBeGreaterThan(0);
expect(screen.getByText("截止：2026-09-22 · 开始未定")).toBeInTheDocument();
fireEvent.click(screen.getByRole("button", { name: "排期" }));

// Inverted task bar is clamped chronologically without negative width
const invBar = screen.getByRole("button", { name: /^Inverted dates task: / });
expect(invBar).toBeInTheDocument();
const invLeft = parseFloat(invBar.style.left.match(/([\d.]+)%/)![1]);
const invWidth = parseFloat(invBar.style.width.match(/([\d.]+)%/)![1]);
expect(invLeft).toBeGreaterThanOrEqual(0);
expect(invWidth).toBeGreaterThan(0);

// Span task covering beyond the window boundaries is clamped to [0%, 100%]
const spanBar = screen.getByRole("button", { name: /^Span task across window: / });
expect(spanBar).toBeInTheDocument();
expect(spanBar.style.left).toBe("0%");
expect(spanBar.style.width).toBe("100%");

// Partially invalid date task uses the valid date safely without NaN
const partialBar = screen.getByRole("button", { name: /^Partially invalid date task: / });
expect(partialBar).toBeInTheDocument();
const partialLeft = parseFloat(partialBar.style.left.match(/([\d.]+)%/)![1]);
const partialWidth = parseFloat(partialBar.style.width.match(/([\d.]+)%/)![1]);
expect(Number.isFinite(partialLeft)).toBe(true);
expect(Number.isFinite(partialWidth)).toBe(true);
expect(partialLeft).toBeGreaterThanOrEqual(0);
expect(partialWidth).toBeGreaterThan(0);
expect(screen.getByText("截止：2026-09-22 · 开始未定")).toBeInTheDocument();
} finally {
vi.useRealTimers();
}
});

it("surfaces project.deleteTaskFail error message when deletion fails", async () => {
Expand Down
Loading