Repository navigation
feat(vault): add workspace notebook snapshot and revision commits - #235
Merged
Merged
Conversation
Closes #234. Add bounded workspace-scoped logical note identity, immutable revisions, tombstones, discovery, and snapshot/commit HTTP endpoints. Record compatibility boundaries and isolated PostgreSQL validation.
Refs #234. Replace the unpatched braces dependency graph with official Tailwind/PostCSS 4 and typescript-eslint 8; retain the existing theme and utility behavior with browser compatibility checks. Linux and Windows audit thresholds remain unchanged and report zero findings. All 109 Web tests, production build and browser acceptance pass.
Refs #234. Former anonymous MinIO/mc image pulls fail before lifecycle setup. Verify fixed official source archive hashes, build a run-specific test image and remove owned resources without changing production assets or assertions. Record CI baseline causes, public advisories, complete Web validation and the full lifecycle run with Go 1.25.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add workspace-scoped Vault discovery, snapshots and atomic delta commits. Logical note IDs keep identical and empty notes distinct; whole-Vault CAS rejects competing stale edits with 409. Immutable revisions, mutable heads and tombstones preserve note identity and history.
Closes #234. Client integration: bytefolk/roleweave#575.
Behavior and boundaries
CI baseline repair
The first run failed on unchanged vulnerable Web dependencies and an unavailable public MinIO image, before exercising Vault code. Remove the unpatched braces chain with official Tailwind/PostCSS 4 and typescript-eslint 8; retain the existing theme and utility behavior with browser compatibility tests. Build test-only MinIO/mc images from checksum-pinned official sources and preserve isolation and every lifecycle assertion. Audit thresholds, checks and timeouts remain unchanged.
Validation
Local PASS: complete Go build/vet/unit/race; full disposable PostgreSQL integration and integration-race; clean Web install, zero-finding Linux/Windows audits, 109 unit tests, lint/typecheck/build, all browser acceptance; complete HTTP/CLI/MCP lifecycle with CI-exact Go 1.25.0. Test resources were removed.
Remote verification on
18db8a26791b3827b86e8d3c9e11fec5ac171999: all 21 checks and all 12 required checks pass, including CI and Windows audit and full PostgreSQL/HTTP/CLI/MCP/browser validation. Non-author CODEOWNERS approval remains required. Public advisory sources, compatibility checks and exact evidence: validation ledger.Administrator merge authorization
The repository administrator explicitly requested direct merging after all CI checks passed. A temporary review-only exception for the current administrator was used to squash-merge exact head
18db8a26791b3827b86e8d3c9e11fec5ac171999. The original review policy was immediately restored; independent verification confirmed that the complete branch-protection configuration matches its original state. Required CI checks and administrator enforcement stayed enabled throughout.