Repository navigation
feat: add shared Select facade - #32
Merged
Merged
Conversation
PeterGuy326
approved these changes
Sep 28, 2026
PeterGuy326
left a comment
Contributor
There was a problem hiding this comment.
Reviewed head 4a82fce. Clean facade: keeps Ant Design's SelectProps/option model intact, layers invalid -> status='error' + aria-invalid, and exposes the stable .ui-select hook so product code stops re-deriving it. The aria-invalid ?? invalid order respects an explicit aria-invalid. CSS adds the minimal width:100% baseline; tests cover the hook, invalid state and accessible name. No blockers. Approving — unblocks roleweave #522.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
Summary
Selectfacade over Ant Design with a stableui-selecthookinvalidstate for product formsValidation
npm run format:checknpm run lintnpm run typechecknpm run test(24 passing)npm run buildnpm run check:dist-tokensnpm run test:packnpm run test:visual -- --grep 'aligns reading content'(1 passing)npm run checkreached the full screenshot suite and found a pre-existing 67,403-pixel drift in theshowcase-light.pngbaseline. The showcase has no Select usage, so this change cannot affect that page; I left the unrelated baseline untouched.