Skip to content

refactor: pre-workspaces cleanups#233

Merged
mkatychev merged 2 commits into
mainfrom
mkatychev/refactor/pre-wkg-workspaces
Jul 11, 2026
Merged

refactor: pre-workspaces cleanups#233
mkatychev merged 2 commits into
mainfrom
mkatychev/refactor/pre-wkg-workspaces

Conversation

@mkatychev

Copy link
Copy Markdown
Member

Split changes from #231 in preparation for WorkspaceConfig/WorkspaceRootConfig additions.

  • added PackageRef to Error::VersionAlreadyExists:
    #[error("{0}@{1} already exists in the registry")]
    VersionAlreadyExists(PackageRef, semver::Version),
  • introduce pub const WIT_DEPS_DIR:
    /// Directory holding WIT dependencies for one or more packages
    pub const WIT_DEPS_DIR: &str = "deps";
  • add PublishVerifier to reuse logic between current multi package publishing eventual workspace fetching found in feat(wkg,core,client): intial wkg workspace approach #231:
    /// A [`CachingClient`] and [`PublishPlan`] wired to a temporary local backend
    pub(crate) struct PublishVerifier {
    #[expect(dead_code, reason = "workspaces")]
    pub(crate) client: CachingClient<FileCache>,
    pub(crate) plan: PublishPlan,
    #[expect(dead_code, reason = "workspaces")]
    pub(crate) packages: BTreeSet<PackageRef>,
    pub(crate) data: HashMap<PackageRef, Vec<u8>>,
    /// Held so the temp local backend outlives the returned client.
    _local_config: LocalConfig,
    }

Changes in preparation for `WorkspaceConfig`/`WorkspaceRootConfig` additions.
@mkatychev mkatychev requested a review from vados-cosmonic July 10, 2026 22:06

@vados-cosmonic vados-cosmonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mkatychev mkatychev merged commit af0b2fc into main Jul 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants