Skip to content

ci: adopt org-wide reusable library pipeline - #10

Merged
msalvatti merged 1 commit into
mainfrom
ci/adopt-reusable-workflows
Jul 9, 2026
Merged

ci: adopt org-wide reusable library pipeline#10
msalvatti merged 1 commit into
mainfrom
ci/adopt-reusable-workflows

Conversation

@msalvatti

Copy link
Copy Markdown
Member

What

Adopt the org-wide reusable CI (bymaxone/.github) for this library, replacing the single monolithic build job.

Changes

  • cinode-lib-ci.yml@v1 — shared lint, type-check, unit+coverage, and gated mutation.
  • Repo-specific local jobs kept: verify (build + bundle-size budget), e2e (Testcontainers Redis, image pre-pulled), example (build + lint nest-queue-example), and secret-scan (trufflehog verified-only).
  • securitysecurity.yml@v1 — dependency review, gated on github.event.repository.visibility == 'public' so it activates automatically and never fails while private.
  • Dependabot added (weekly npm + github-actions) for zero-CI-minute dependency/security scanning.
  • Mutation now runs automatically post-merge on main (source-gated, incremental) via the shared reusable — never on PRs, never on a schedule.

Notes

  • CodeQL default setup disabled at the repo level so the version-controlled advanced codeql.yml remains the single source of truth (both cannot coexist).

Replace the monolithic build job with a thin caller of the shared
bymaxone/.github reusables:

- ci → node-lib-ci.yml@v1 (lint, typecheck, unit+coverage, gated mutation)
- keep build+size, Testcontainers Redis e2e, example build, and the
  verified-secret scan as repo-specific local jobs
- add visibility-gated dependency review (security.yml@v1)
- add weekly Dependabot for npm + github-actions

Mutation now runs post-merge on main via the shared reusable instead of
only as a pre-release manual step.
Copilot AI review requested due to automatic review settings July 9, 2026 18:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR switches the repository CI to a thin “caller” workflow that delegates standard Node library checks (lint, typecheck, unit+coverage, mutation-on-main) to the org-wide reusable pipeline in bymaxone/.github, while keeping repo-specific build/size verification, Redis Testcontainers E2E, example app checks, and a verified-only secret scan locally.

Changes:

  • Replace the monolithic CI job with bymaxone/.github/.github/workflows/node-lib-ci.yml@v1 plus local verify, e2e, example, and secret-scan jobs.
  • Add a gated dependency-review job via bymaxone/.github/.github/workflows/security.yml@v1 (public-repo only).
  • Add weekly Dependabot updates for npm and GitHub Actions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
CLAUDE.md Updates contributor guidance to reflect mutation testing running post-merge on main via the shared reusable workflow.
.github/workflows/ci.yml Refactors CI into a reusable-workflow caller plus repo-specific verification/E2E/example/secret-scan/security jobs.
.github/dependabot.yml Adds weekly Dependabot config for npm and GitHub Actions updates.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
@msalvatti
msalvatti merged commit e6f44aa into main Jul 9, 2026
18 checks passed
@msalvatti
msalvatti deleted the ci/adopt-reusable-workflows branch July 9, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants