fix: accept lists for custom actions with nargs - #357
Open
lo-0l wants to merge 1 commit into
Open
Conversation
The list-value check in convert_item_to_command_line_arg required the action to be a _StoreAction or _AppendAction instance, so an argument declared with a custom argparse.Action subclass and nargs="+" was rejected when its value came from a config file, even though the same argument parsed fine from the command line. The class check is not what the error message advertises, and it is redundant: actions that cannot consume several values (store_const, count, help, ...) already have nargs == 0 or None, so they still fall through to the error. Keep the nargs test only. Fixes bw2#354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list-value check in convert_item_to_command_line_arg required the action to be a _StoreAction or _AppendAction instance, so an argument declared with a custom argparse.Action subclass and nargs="+" was rejected when its value came from a config file, even though the same argument parsed fine from the command line.
The class check is not what the error message advertises, and it is redundant: actions that cannot consume several values (store_const, count, help, ...) already have nargs == 0 or None, so they still fall through to the error. Keep the nargs test only.
Fixes #354