feat: 校对字幕支持单行删除#369
Open
nightt5879 wants to merge 1 commit into
Open
Conversation
|
@nightt5879 is attempting to deploy a commit to the buxuku's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
感谢 PR!实现思路和我们几乎完全一致(同样基于 range-command 的可撤销删除 + currentIndex 重整),代码质量很好。 同样抱歉的是,这个功能我刚在 你给按钮加 aria-label 的细节很好,我已经借鉴过来,一并补到了校对行的三个操作按钮上。本 PR 会在功能发布后关闭,再次感谢,期待后续继续参与! |
buxuku
added a commit
that referenced
this pull request
Jul 6, 2026
buxuku
added a commit
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #365
修改内容
实现说明
校对编辑器原有的合并、拆分都通过字幕 hook 统一更新字幕数组和撤销历史。本次删除也复用同一套区间命令模型,把“1 行变 0 行”记录为一条可撤销命令,避免直接修改数组导致历史栈、字幕 ID 或当前播放索引错位。
验证
npm run check:i18nnpm run build