Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 6, 2026 04:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public to_records utility accepts Iterable headers, but passes the same iterable directly to zip for every row. For a generator or iterator, processing the first row exhausts the keys, so later records become empty. Empty or short rows can also shift remaining header keys onto the wrong values.
Materialize the header iterable once before building the records. The regression uses generator headers and rows, starting with an empty row and a short row before multiple complete records, and verifies both correct column mapping and preserved values.
Validation: baseline complete upstream suite 166 passed; regression fails before the fix (wrong column mapping and empty later records); final complete upstream suite 167 passed with no skips or deselections. Pinned Black 24.8.0, codespell, flake8, isort, pinned mypy 1.11.2, Bandit, source/wheel build, Sphinx -W, pyupgrade and git diff --check passed. Black checked all 18 files returned by its own directory discovery individually because the container blocks its multiprocess manager socket; no sources or checks were omitted.
Local validation used CPython 3.11.16/Linux. The upstream interpreter/platform CI matrix has not been run locally. The advisory
pip-auditstep did not run successfully; it is configured as non-blocking in CI and is not counted as passed.Prepared with OpenAI Codex assistance.