Skip to content

v1.0.11 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yilmaztayfun merged 2 commits into from
Aug 3, 2026
Merged

v1.0.11 #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8352a97
fix(api): restore User-Agent header on API requests
yilmaztayfun Aug 3, 2026
5a46540
Merge pull request #41 from burgan-tech/fix/restore-user-agent-header
yilmaztayfun Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/lib/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
const axios = require('axios');
const https = require('node:https');
const http = require('node:http');
const pkg = require('../../package.json');

// Identifies requests as coming from the CLI (e.g. "vnext-workflow-cli/1.0.0")
const USER_AGENT = `vnext-workflow-cli/${pkg.version}`;

// Create axios instance with custom agents for both HTTP and HTTPS
const apiClient = axios.create({
httpAgent: new http.Agent({ keepAlive: true }),
httpsAgent: new https.Agent({
httpsAgent: new https.Agent({
rejectUnauthorized: false // Allow self-signed certificates
})
}),
headers: { 'User-Agent': USER_AGENT }

@sourcery-ai sourcery-ai Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Setting headers at the instance level may override axios’s per-method default headers.

Passing a flat headers object into axios.create can overwrite axios’s per-method defaults (e.g. Content-Type on POST/PUT). To avoid dropping these, either set apiClient.defaults.headers.common['User-Agent'] = USER_AGENT after creation, or use headers: { common: { 'User-Agent': USER_AGENT } } so existing defaults are preserved.

});

/**
Expand All @@ -18,8 +23,7 @@ const apiClient = axios.create({
async function testApiConnection(baseUrl) {
try {
const response = await apiClient.get(`${baseUrl}/health`, {
timeout: 5000,
headers: { 'User-Agent': USER_AGENT }
timeout: 5000
});
return response.status === 200;
} catch (error) {
Expand Down
Loading