test(state-function): pin annotations on scheduled entries, the timeout block and every triggerable kind - #23
Merged
Conversation
Extends two existing scenarios instead of adding one. timeout-lab (flows 1.0.1): the root gains a shared transition, exit and updateData, and every listed entry carries a distinct ui/source annotation, plus timeout.annotations. A new test asserts the state body passes each kind's annotations through and the timeout block carries its own; the SubFlow test now asserts the child's block carries the parent override's annotations (override replaces, no merge). schedule-after-auto (1.0.1): gate-timeout carries an annotation and the armed-entry test asserts the kind:"scheduled" entry exposes it — the runtime used to drop it (vnext#1029). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
annotationsonkind: "scheduled"entries (previously dropped) and on thetimeoutblock (newtimeout.annotations).cancel,exitandupdateDataentries carry their definition's annotations.Changes
timeout-lab-root/timeout-lab-parent→ 1.0.1)root-note(shared,$self),exitandupdateData; every listed entry carries a distinctui/sourceannotation, and the timeout carriesui/countdown: root-deadline. None of the new transitions is ever called — the timeout still does the moving.subFlow.overrides.timeoutcarriesui/countdown: parent-override.RootFlow_StateBodyCarriesTheAnnotationsOfEveryListedEntry;SubFlowChild_ReportsAndHonoursTheParentsTimeoutOverridenow also asserts the override's annotations reach the child.build-schedule-after-auto.py)gate-timeoutcarriesui/countdown: gate-timeout;NoAutoWinner_ArmsTheScheduledTransition_AndItFiresasserts the scheduled entry exposes it.TEST-SCENARIOS.mdrows updated.Test Plan
VNEXT_BASE_URL=http://localhost:4201--filter "FullyQualifiedName~TimeoutLab|FullyQualifiedName~ScheduleAfterAuto"— 6/6SubflowOrchestration+ChainBusy— 37/37; all four together on Aether 1.0.42 — 43/43timeout.annotations; postgres shows instances bound to1.0.1, the child'ssubflow.timeout_overridestamp carrying the parent's annotations, and the scheduled job withSourceState=gate.Notes
npm run validateneeds feat(schema): add annotations to workflowTimeout vnext-schema#140 to formally recognisetimeout.annotations; the field already passes today becauseworkflowTimeoutis an open object, and the SDK publishes directly.🤖 Generated with Claude Code