chore: sync quickjs-ng release v0.15.1#752
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates QuickJS-NG to version 0.15.1, introducing a version flag (-v/--version) in the CLI, support for dumping nested error causes in the libc error utility, and tests for SharedArrayBuffer growth. It also adds compile definitions for mimalloc and updates the documentation. Feedback on the changes points out a potential issue in the error-dumping logic where an exception returned when retrieving the "cause" property is not handled, which could lead to misleading output.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| val = JS_GetPropertyStr(ctx, current, "cause"); | ||
| if (JS_IsUndefined(val)) { | ||
| JS_FreeValue(ctx, val); | ||
| break; | ||
| } |
There was a problem hiding this comment.
If JS_GetPropertyStr returns JS_EXCEPTION (for example, if a getter for cause throws an exception or a proxy trap fails), JS_IsUndefined(val) will be false. This causes the loop to print a misleading Caused by: header followed by [exception] in the next iteration. Checking for JS_IsException(val) and breaking early prevents this.
val = JS_GetPropertyStr(ctx, current, \"cause\");\n if (JS_IsUndefined(val) || JS_IsException(val)) {\n JS_FreeValue(ctx, val);\n break;\n }
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 3831 3831
=========================================
Hits 3831 3831 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Sync vendored quickjs-ng sources to v0.15.1.
Release: https://github.com/quickjs-ng/quickjs/releases/tag/v0.15.1
This PR was generated automatically by the scheduled quickjs-ng release sync workflow.