Skip to content

chore: sync quickjs-ng release v0.15.1#752

Open
buke wants to merge 1 commit into
mainfrom
automation/quickjs-ng-v0.15.1
Open

chore: sync quickjs-ng release v0.15.1#752
buke wants to merge 1 commit into
mainfrom
automation/quickjs-ng-v0.15.1

Conversation

@buke
Copy link
Copy Markdown
Owner

@buke buke commented Jun 5, 2026

Sync vendored quickjs-ng sources to v0.15.1.

Release: https://github.com/quickjs-ng/quickjs/releases/tag/v0.15.1

This PR was generated automatically by the scheduled quickjs-ng release sync workflow.

@buke buke added automation dependencies Pull requests that update a dependency file labels Jun 5, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates QuickJS-NG to version 0.15.1, introducing a version flag (-v/--version) in the CLI, support for dumping nested error causes in the libc error utility, and tests for SharedArrayBuffer growth. It also adds compile definitions for mimalloc and updates the documentation. Feedback on the changes points out a potential issue in the error-dumping logic where an exception returned when retrieving the "cause" property is not handled, which could lead to misleading output.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +4748 to +4752
val = JS_GetPropertyStr(ctx, current, "cause");
if (JS_IsUndefined(val)) {
JS_FreeValue(ctx, val);
break;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If JS_GetPropertyStr returns JS_EXCEPTION (for example, if a getter for cause throws an exception or a proxy trap fails), JS_IsUndefined(val) will be false. This causes the loop to print a misleading Caused by: header followed by [exception] in the next iteration. Checking for JS_IsException(val) and breaking early prevents this.

        val = JS_GetPropertyStr(ctx, current, \"cause\");\n        if (JS_IsUndefined(val) || JS_IsException(val)) {\n            JS_FreeValue(ctx, val);\n            break;\n        }

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1d5c2cf) to head (7cc1e47).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #752   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         3831      3831           
=========================================
  Hits          3831      3831           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5c2cf...7cc1e47. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant