Add nonce support for triggering services - #1117
Closed
1AhmedYasser wants to merge 5 commits into
Closed
Conversation
4 tasks
1AhmedYasser
marked this pull request as ready for review
July 16, 2026 10:12
trevorling
requested changes
Jul 20, 2026
|
|
||
| guard_fail: | ||
| return: "unauthorized" | ||
| status: 403 |
Contributor
There was a problem hiding this comment.
Why it's 403 instead of 401?
403 - Forbidden
401 - Unauthorized
|
|
||
| guard_fail: | ||
| return: "unauthorized" | ||
| status: 403 |
Contributor
There was a problem hiding this comment.
Why it's 403 instead of 401?
403 - Forbidden
401 - Unauthorized
|
|
||
| guard_fail: | ||
| return: "unauthorized" | ||
| status: 403 |
Contributor
There was a problem hiding this comment.
Why it's 403 instead of 401?
403 - Forbidden
401 - Unauthorized
|
|
||
| guard_fail: | ||
| return: "unauthorized" | ||
| status: 403 |
Contributor
There was a problem hiding this comment.
Why it's 403 instead of 401?
403 - Forbidden
401 - Unauthorized
|
|
||
| guard_fail: | ||
| return: "unauthorized" | ||
| status: 403 |
Contributor
There was a problem hiding this comment.
Why it's 403 instead of 401?
403 - Forbidden
401 - Unauthorized
|
|
||
| guard_fail: | ||
| return: "unauthorized" | ||
| status: 403 |
Contributor
There was a problem hiding this comment.
Why it's 403 instead of 401?
403 - Forbidden
401 - Unauthorized
1AhmedYasser
added a commit
to 1AhmedYasser/Service-Module
that referenced
this pull request
Jul 30, 2026
401 Unauthorized is the correct status for a missing/invalid nonce or authentication, per review feedback on PR buerokratt#1117. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
401 Unauthorized is the correct status for a missing/invalid nonce or authentication, per review feedback on PR buerokratt#1117.
1AhmedYasser
force-pushed
the
Add-nonce-support-for-triggering-services
branch
from
July 30, 2026 10:04
810d3ac to
2e9280a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Task: