fix(fdc): remove ReadDiagnostic OSD toast during gameplay - #30
Merged
Merged
Conversation
Read Diagnostic (FDC command 2) is a routine track-level disk access some titles use for verification/copy-protection checks. It was being surfaced via statusdisplay.Show() unconditionally, unlike other FDC commands that gate behind the "Show FDC Status" option, so it kept popping up as an on-screen toast during normal gameplay (e.g. the Sorcerian opening) with no way to suppress it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rg91L7dcSjpYirGT9hWZXU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadDiagnostic (DrX TrY)のOSDトーストを削除Test plan
cmake --build .でビルドが通ることを確認src/pc88/fdc.cppの変更差分が意図通り（ReadDiagnostic用のstatusdisplay.Show()呼び出しとトラック番号算出のみ削除）であることを確認🤖 Generated with Claude Code
https://claude.ai/code/session_01Rg91L7dcSjpYirGT9hWZXU