Skip to content

Separate signed release preparation from Store distribution - #491

Merged
btsouth merged 2 commits into
mainfrom
ci/latency-20261002
Oct 2, 2026
Merged

btsouth merged 2 commits into
mainfrom
ci/latency-20261002

Conversation

@btsouth

@btsouth btsouth commented Oct 2, 2026 •

Copy link
Copy Markdown
Owner

The Windows release job currently waits on R2 upload and Partner Center. Move those steps into dependent jobs that download the exact same-run signed artifacts, leaving signed installer verification, release doctor and draft creation in the build job. Preserve the manual draft publication policy and serialize Store submissions.

Validation: actionlint 1.7.12 and git diff --check pass; independent review checked release dependencies and artifact identity. Live signing, R2 and Partner Center were not invoked.

Remove the blanket approval requirement for routine authorized work in AGENTS.md; required merge/release validation remains intact.

Note

Split Store submission and upload into separate release jobs

  • Restructures the release workflow in release.yml: the Windows release job now outputs its validated version, a new release.store-upload job downloads the versioned signed artifact and uploads it, and release.submit-store waits for both before submitting to the Microsoft Store
  • Moves the always-run Azure logout cleanup from the Store submission job to the end of the Windows release job
  • The Store submission job uses a non-canceling concurrency group so an in-progress submission is not canceled by a new run
  • Adds a 20-minute limit to the frontend CI job in ci.yml and a 30-minute limit to the Store submission job
  • Risk: release jobs now depend on the Validate tag and version step output in release.yml; if that step's id or output name changes, the version passed to upload and submission jobs breaks

Macroscope summarized 9f09e4a.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 08133418-8307-4f2e-812c-d1131ce655f5
📥 Commits

Reviewing files that changed from the base of the PR and between 4775ac6 and 9f09e4a.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml
  • AGENTS.md
 ____________________________________
< LLM (Looking for Leaks in Memory). >
 ------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ceiling 9f09e4a Commit Preview URL

Branch Preview URL
Oct 02 2026, 11:17 PM

@btsouth
btsouth marked this pull request as ready for review October 2, 2026 23:23
@btsouth
btsouth merged commit b5bfece into main Oct 2, 2026
11 checks passed
@btsouth
btsouth deleted the ci/latency-20261002 branch October 2, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant