Fix Overview scrolling when provider list exceeds window height - #490
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Overview menu stack now sets ChangesOverview menu stack
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The Overview’s provider rows remain reachable by scrolling the dashboard body. No concrete merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Overview now scrolls through all provider rows in short windows. This prepares 1.5.43 with the fix from #490 and dependency and Windows clippy maintenance already on main. Updates the release versions and lock entries, and credits @jayn2u in the changelog. The scrolling fix passed exact-build interactive Windows wheel, scrollbar and keyboard checks at 100% and 125% app zoom. Frontend and version checks run on devbox; hosted CI covers Windows Rust validation before merge. <!-- Macroscope's pull request summary starts here --> <!-- Macroscope will only edit the content between these invisible markers, and the markers themselves will not be visible in the GitHub rendered markdown. --> <!-- If you delete either of the start / end markers from your PR's description, Macroscope will append its summary at the bottom of the description. --> > [!NOTE] > ### Prepare Ceiling 1.5.43 release > Bumps the version from 1.5.42 to 1.5.43 across the desktop package, Tauri config, Rust package, and [version.env](https://github.com/tsouth89/ceiling/pull/494/files#diff-24666480479ab50e1706bcf466adbdd3ef34ed64352c9882bc41085e4bbb76fd). Adds a 1.5.43 entry to [CHANGELOG.md](https://github.com/tsouth89/ceiling/pull/494/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed) covering overview scrolling for all providers plus internal dependency and Windows clippy updates. Updates [Cargo.lock](https://github.com/tsouth89/ceiling/pull/494/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e) accordingly. > > <!-- Macroscope's review summary starts here --> > > <sup><a href="https://app.macroscope.com">Macroscope</a> summarized 0747b18.</sup> > <!-- Macroscope's review summary ends here --> > <!-- Macroscope's pull request summary ends here -->
Summary
I removed the Overview list height cap so the dashboard body can scroll to all provider rows.
Only one CSS declaration is changed. No test files or provider/backend changes are included.
Validation
Fixes #489
Note
Fix Overview scrolling by removing max-height on provider list
Removes the max-height limit on the overview menu stack in styles.css, so the provider list can use its natural height and scroll correctly when it exceeds the window height. Overflow stays hidden and other layout styling is unchanged.
Macroscope summarized 73a75c8.
Summary by CodeRabbit