Skip to content

Fix Overview scrolling when provider list exceeds window height - #490

Merged
btsouth merged 1 commit into
btsouth:mainfrom
jayn2u:fix/overview-scroll
Oct 3, 2026
Merged

btsouth merged 1 commit into
btsouth:mainfrom
jayn2u:fix/overview-scroll

Conversation

@jayn2u

@jayn2u jayn2u commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

I removed the Overview list height cap so the dashboard body can scroll to all provider rows.

Only one CSS declaration is changed. No test files or provider/backend changes are included.

Validation

  • Verified in an Edge layout reproduction that the dashboard scrolls and the last row is reachable.
  • git diff --check passed.
  • The earlier local Tauri build and frontend test suite passed before unrelated local changes were removed; the cleaned tree has not been rebuilt.

Fixes #489

Note

Fix Overview scrolling by removing max-height on provider list

Removes the max-height limit on the overview menu stack in styles.css, so the provider list can use its natural height and scroll correctly when it exceeds the window height. Overflow stays hidden and other layout styling is unchanged.

Macroscope summarized 73a75c8.

Summary by CodeRabbit

  • Bug Fixes
    • The dashboard overview menu can now expand beyond its previous height limit, preventing its content from being constrained.

@jayn2u
jayn2u requested a review from btsouth as a code owner October 2, 2026 07:00
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ff2bd442-72b6-4aac-9471-d1f7be62dda4

📥 Commits

Reviewing files that changed from the base of the PR and between 4775ac6 and 73a75c8.

📒 Files selected for processing (1)
  • apps/desktop-tauri/src/styles.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Overview menu stack now sets max-height: none, overriding the inherited height limit.

Changes

Overview menu stack

Layer / File(s) Summary
Override the Overview height limit
apps/desktop-tauri/src/styles.css
The Overview menu stack sets max-height: none to override the inherited height limit.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 73a75

The Overview’s provider rows remain reachable by scrolling the dashboard body. No concrete merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 73a75

The change affects 1 system.

Changed systems: apps/desktop-tauri

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/desktop-tauri (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/desktop-tauri/src/styles.css: The overview stack no longer has a maximum height, overriding the inherited height limit.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing Overview scrolling when the provider list exceeds the window height.
Linked Issues check ✅ Passed The direct issue is #489. The change sets .menu-stack--overview max-height to none, which removes the inherited height cap. The PR summary reports that the dashboard body scrolls and that the la…
Out of Scope Changes check ✅ Passed The reported change contains one CSS override for .menu-stack--overview. The override directly supports issue #489 by removing the height constraint that prevents access to lower provider rows. The …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@btsouth
btsouth merged commit 30dd260 into btsouth:main Oct 3, 2026
7 checks passed
@btsouth btsouth mentioned this pull request Oct 3, 2026
btsouth added a commit that referenced this pull request Oct 3, 2026
Overview now scrolls through all provider rows in short windows. This
prepares 1.5.43 with the fix from #490 and dependency and Windows clippy
maintenance already on main.

Updates the release versions and lock entries, and credits @jayn2u in
the changelog. The scrolling fix passed exact-build interactive Windows
wheel, scrollbar and keyboard checks at 100% and 125% app zoom. Frontend
and version checks run on devbox; hosted CI covers Windows Rust
validation before merge.


<!-- Macroscope's pull request summary starts here -->
<!-- Macroscope will only edit the content between these invisible
markers, and the markers themselves will not be visible in the GitHub
rendered markdown. -->
<!-- If you delete either of the start / end markers from your PR's
description, Macroscope will append its summary at the bottom of the
description. -->
> [!NOTE]
> ### Prepare Ceiling 1.5.43 release
> Bumps the version from 1.5.42 to 1.5.43 across the desktop package,
Tauri config, Rust package, and
[version.env](https://github.com/tsouth89/ceiling/pull/494/files#diff-24666480479ab50e1706bcf466adbdd3ef34ed64352c9882bc41085e4bbb76fd).
Adds a 1.5.43 entry to
[CHANGELOG.md](https://github.com/tsouth89/ceiling/pull/494/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed)
covering overview scrolling for all providers plus internal dependency
and Windows clippy updates. Updates
[Cargo.lock](https://github.com/tsouth89/ceiling/pull/494/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e)
accordingly.
>
> <!-- Macroscope's review summary starts here -->
>
> <sup><a href="https://app.macroscope.com">Macroscope</a> summarized
0747b18.</sup>
> <!-- Macroscope's review summary ends here -->
>
<!-- Macroscope's pull request summary ends here -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overview content cannot be scrolled when provider list exceeds window height

2 participants