Skip to content

Allow null property GUI values #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btoron merged 1 commit into from
Jun 1, 2026
Merged

Allow null property GUI values #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ofsc/models/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,6 +829,8 @@ def set_default(cls, field_value, values):
@field_validator("gui")
@classmethod
def gui_match(cls, v):
if v is None:
return v
if v not in [
"text",
"checkbox",
Expand Down
14 changes: 14 additions & 0 deletions tests/metadata/test_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,20 @@ def test_get_properties(instance, demo_data):
assert response["items"][0]["label"] == "ITEM_NUMBER"


def test_property_accepts_explicit_null_gui():
property_obj = Property.model_validate(
{
"label": "foo",
"name": "Foo",
"type": "string",
"gui": None,
"translations": [{"language": "en", "name": "Foo"}],
}
)

assert property_obj.gui is None


@pytest.mark.serial
@pytest.mark.uses_real_data
def test_create_replace_property(instance: OFSC, faker):
Expand Down
Loading