Skip to content

Removing velocity and channel attributes of Note class#83

Open
PettaBoy wants to merge 1 commit into
bspaans:masterfrom
PettaBoy:patch-2
Open

Removing velocity and channel attributes of Note class#83
PettaBoy wants to merge 1 commit into
bspaans:masterfrom
PettaBoy:patch-2

Conversation

@PettaBoy

@PettaBoy PettaBoy commented Sep 5, 2021

Copy link
Copy Markdown
Contributor

This has been mentioned by several people also.

@edudobay

edudobay commented Sep 7, 2021

Copy link
Copy Markdown
Collaborator

Hi @PettaBoy, what exactly is the purpose of this change? The velocity and channel attributes are still referenced by other methods. Also, they are used in several places across the codebase, so there's more to removing them than just removing these two lines.

@PettaBoy

PettaBoy commented Sep 9, 2021

Copy link
Copy Markdown
Contributor Author

I understand that @edudobay, but this is becoming a big problem in the development of one of my applications.
If I leave the code alone, then I might not be able to change the program of the keyboard unless I am at channel 1. This will severely affect the chances of me developing a multi channel application in the future. Also, the keyboard won't be able to play the MIDI percussion instruments with the current code.
My bad, though. Should have done more research before putting this out.
Here's the Github repo of the app if you want to check it out:
https://github.com/PettaBoy/VirtualMusicKeyboard

@PettaBoy

PettaBoy commented Sep 10, 2021

Copy link
Copy Markdown
Contributor Author

Thought I'll reference #21 and #22 to this as well. Unfortunately it got closed by the author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants