Repository navigation
fix: retain dependency review prompts when lockfiles are deleted - #8
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-authored-by: nyctophile <brunnodevtools@gmail.com>
ineedfoundmyway
force-pushed
the
fix/deleted-lockfile-review
branch
from
November 4, 2026 02:42
5e564f3 to
5264139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A patch that changes a dependency manifest and deletes its lockfile currently suppresses the dependency reproducibility prompt, because the rule counts every recognized lockfile path regardless of deletion status. Only lockfiles kept or added by the patch now suppress that prompt.
Adds regression coverage for Git and plain unified deletions, renaming a lockfile away, and replacing a removed npm lockfile with a pnpm lockfile. Existing modified-lockfile coverage remains in place. Updates the finding text and README to describe the behavior accurately; reports still describe the patch rather than the whole repository.
Validation:
npm run check,npm test(21 passed),npm run demo(4 files, 5 prompts), andgit diff --check.