Skip to content

fix: retain dependency review prompts when lockfiles are deleted - #8

Merged
brunnojob merged 1 commit into
mainfrom
fix/deleted-lockfile-review
Nov 4, 2026
Merged

brunnojob merged 1 commit into
mainfrom
fix/deleted-lockfile-review

Conversation

@ineedfoundmyway

Copy link
Copy Markdown
Collaborator

A patch that changes a dependency manifest and deletes its lockfile currently suppresses the dependency reproducibility prompt, because the rule counts every recognized lockfile path regardless of deletion status. Only lockfiles kept or added by the patch now suppress that prompt.

Adds regression coverage for Git and plain unified deletions, renaming a lockfile away, and replacing a removed npm lockfile with a pnpm lockfile. Existing modified-lockfile coverage remains in place. Updates the finding text and README to describe the behavior accurately; reports still describe the patch rather than the whole repository.

Validation: npm run check, npm test (21 passed), npm run demo (4 files, 5 prompts), and git diff --check.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T02:41:56.910635Z 5e564f3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-authored-by: nyctophile <brunnodevtools@gmail.com>
@ineedfoundmyway
ineedfoundmyway force-pushed the fix/deleted-lockfile-review branch from 5e564f3 to 5264139 Compare November 4, 2026 02:42
@brunnojob
brunnojob merged commit 7d92562 into main Nov 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants