Skip to content

test: prevent SDK parity notification timeout - #2781

Open
miguelg719 wants to merge 1 commit into
mainfrom
fix/sdk-parity-test-timeout
Open

test: prevent SDK parity notification timeout#2781
miguelg719 wants to merge 1 commit into
mainfrom
fix/sdk-parity-test-timeout

Conversation

@miguelg719

@miguelg719 miguelg719 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • give the full cross-SDK notification parity scan a 15-second test timeout
  • keep the default 5-second timeout for the rest of the unit suite

Root cause

The notification parity test recursively parses the TypeScript, Python, and Go SDKs. Under concurrent CI load it took 5.066 seconds, narrowly exceeding Vitest's default 5-second timeout.

Validation

  • pnpm run test:unit (93 passed)
  • pnpm exec oxfmt --check rules/ast-grep/sdk-parity.test.ts
  • pnpm exec oxlint rules/ast-grep/sdk-parity.test.ts

Summary by cubic

Prevents CI flakiness by increasing the vitest timeout for the notification parity test from 5s to 15s. Previously this test occasionally exceeded 5s under load and timed out; now only this test uses 15s, the rest keep the default 5s, and there’s no runtime impact.

Written for commit 0a47c54. Summary will update on new commits.

Review in cubic

@changeset-bot

changeset-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0a47c54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant