Skip to content

feat(evals v4): OTEL agent spans for claude_code/codex harnesses #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelg719 merged 1 commit into from
Aug 24, 2026
Merged

feat(evals v4): OTEL agent spans for claude_code/codex harnesses #2761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 41 additions & 22 deletions packages/evals/framework/benchHarness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
import { runCodexAgent } from "./codexRunner.js";
import { prepareCodexToolAdapter, type PreparedCodexToolAdapter } from "./codexToolAdapter.js";
import { buildExternalHarnessTaskPlan } from "./externalHarnessPlan.js";
import { withHarnessAgentSpan } from "./otel.js";
import type { DiscoveredTask, TaskResult } from "./types.js";
import type { BenchMatrixRow, BenchTaskKind, Harness } from "./benchTypes.js";

Expand Down Expand Up @@ -160,18 +161,27 @@ export const claudeCodeHarness: BenchHarness = {
plan,
logger,
});
return await runClaudeCodeAgent({
plan,
model: input.modelName,
logger,
toolAdapter,
signal,
verifier: {
v3: carrierV3,
taskSpec: buildExternalHarnessTaskSpec(plan, input),
dataset: plan.dataset,
return await withHarnessAgentSpan(
Comment thread
miguelg719 marked this conversation as resolved.
{
harness: "claude_code",
model: input.modelName,
task: input.name,
instruction: plan.instruction,
},
});
() =>
runClaudeCodeAgent({
plan,
model: input.modelName,
logger,
toolAdapter,
signal,
verifier: {
v3: carrierV3,
taskSpec: buildExternalHarnessTaskSpec(plan, input),
dataset: plan.dataset,
},
}),
);
} finally {
await toolAdapter?.cleanup();
// Deregister the never-init()-ed carrier (instance registry, event
Expand Down Expand Up @@ -209,18 +219,27 @@ export const codexHarness: BenchHarness = {
plan,
logger,
});
return await runCodexAgent({
plan,
model: input.modelName,
logger,
toolAdapter,
signal,
verifier: {
v3: carrierV3,
taskSpec: buildExternalHarnessTaskSpec(plan, input),
dataset: plan.dataset,
return await withHarnessAgentSpan(
{
harness: "codex",
model: input.modelName,
task: input.name,
instruction: plan.instruction,
},
});
() =>
runCodexAgent({
plan,
model: input.modelName,
logger,
toolAdapter,
signal,
verifier: {
v3: carrierV3,
taskSpec: buildExternalHarnessTaskSpec(plan, input),
dataset: plan.dataset,
},
}),
);
} finally {
await toolAdapter?.cleanup();
// Deregister the never-init()-ed carrier (instance registry, event
Expand Down
Loading