Skip to content

Adding parallelization via sbatch#2

Open
broarr wants to merge 1 commit into
masterfrom
parallelize
Open

Adding parallelization via sbatch#2
broarr wants to merge 1 commit into
masterfrom
parallelize

Conversation

@broarr

@broarr broarr commented Aug 27, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@mcmcgrath13 mcmcgrath13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to my untrained eye, looks pretty good! could perhaps use some comments on what the functions do at a high level

Comment thread src/main.rs
);
let force = if options.force { "-F" } else { "" };

let memory = option_env!("SBATCH_MEM_PER_NODE");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be worth making a util that does this pattern since it's used quite a bit?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling there's a rust-ism that I'm missing here. Maybe I need to employ the ? operator and some other magic?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dev-notes.eu/2020/05/Set-Default-Values-in-Rust/

Apparently I can do option_env!("FOO").unwrap_or("my value");?

@mirestrepo

Copy link
Copy Markdown

@broarr do you remember if this worked? I have a vague memory of you mentioning it didn't... but I wanted to see if this is something we should looking into picking up and exploring again, or do we close and stay sequential or handle paralellization outside of Rust (batch box instead). Any knowledge dump would help us. Thanks!

@broarr

broarr commented Oct 20, 2022 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants